[castor-dev] CPA test suite

Discussion:

Werner Guttmann

2009-06-11 12:03:51 UTC

Hi,

I am about to commit quite a big patch that introduces JPA annotation
support. Problem is, it looks like there's a few tests failing for me
within the CPACTF (all of them in the test70 package).

Any idea what's going wrong here ? It looks like all of them are related
to the use of JUnit and inner classes, but I am not sure.

** log output ***

Running org.castor.cpa.test.test25.Group
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec
Running org.castor.cpa.test.test2567.TestQuery
11.06.2009 13:55:48 org.exolab.castor.mapping.Mapping loadMapping
INFO: Loading mapping descriptors from
/org/castor/cpa/test/test2567/mapping.xml
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec

Results :

Tests in error:
initializationError0(org.castor.cpa.test.test70.ColArray$1)
initializationError1(org.castor.cpa.test.test70.ColArray$1)
initializationError0(org.castor.cpa.test.test70.Col$1)
initializationError1(org.castor.cpa.test.test70.Col$1)

Tests run: 324, Failures: 0, Errors: 4, Skipped: 163

[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] There are test failures.

Please refer to
D:\src\castor\castorJPA20090610\cpactf\target\surefire-reports for the
individual test results.
[INFO]
------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 2 minutes 9 seconds
[INFO] Finished at: Thu Jun 11 13:55:48 CEST 2009
[INFO] Final Memory: 16M/49M
[INFO]
------------------------------------------------------------------------

*****

Cheers
Werner

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Ralf Joachim

2009-06-11 16:20:11 UTC

Permalink

Hi Werner,

we have had problems with mavens test collector and inner classes
before. They only happend on windows systems and i was not able to
reproduce them on linux. I tried to prevent this by ignore annotations
at every class that is not a test case. At least the inner class of Col
has a ignore annotation (at inner class of ColArray it is missing).

The only solution I found the last time we saw this problem was to
remove all inner classes and use normal ones instead. Before doing this,
can you please test 2 things:

- Does the problem also happen at SVN head?
- Do you see similar problems if you execute tests with eclipse test
collector?

As it looks to me this is a problem of mavens test collector that should
be reported to the maven team. Only thing we can do is to not use inner
classes in our test cases and objects. Having said that you or Lukas
will need inner classes to test all JPA features.

Regards
Ralf

Post by Werner Guttmann
Hi,
I am about to commit quite a big patch that introduces JPA annotation
support. Problem is, it looks like there's a few tests failing for me
within the CPACTF (all of them in the test70 package).
Any idea what's going wrong here ? It looks like all of them are related
to the use of JUnit and inner classes, but I am not sure.
** log output ***
Running org.castor.cpa.test.test25.Group
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec
Running org.castor.cpa.test.test2567.TestQuery
11.06.2009 13:55:48 org.exolab.castor.mapping.Mapping loadMapping
INFO: Loading mapping descriptors from
/org/castor/cpa/test/test2567/mapping.xml
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec
initializationError0(org.castor.cpa.test.test70.ColArray$1)
initializationError1(org.castor.cpa.test.test70.ColArray$1)
initializationError0(org.castor.cpa.test.test70.Col$1)
initializationError1(org.castor.cpa.test.test70.Col$1)
Tests run: 324, Failures: 0, Errors: 4, Skipped: 163
[INFO]
------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] There are test failures.
Please refer to
D:\src\castor\castorJPA20090610\cpactf\target\surefire-reports for the
individual test results.
[INFO]
------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 2 minutes 9 seconds
[INFO] Finished at: Thu Jun 11 13:55:48 CEST 2009
[INFO] Final Memory: 16M/49M
[INFO]
------------------------------------------------------------------------
*****
Cheers
Werner
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

--
Syscon Ingenieurbüro für Meß- und Datentechnik GmbH
Ralf Joachim
Raiffeisenstraße 11
72127 Kusterdingen
Germany

Tel. +49 7071 3690 52
Mobil: +49 173 9630135
Fax +49 7071 3690 98

Internet: www.syscon.eu
E-Mail: ***@syscon.eu

Sitz der Gesellschaft: D-72127 Kusterdingen
Registereintrag: Amtsgericht Stuttgart, HRB 382295
Geschäftsleitung: Jens Joachim, Ralf Joachim

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Werner Guttmann

2009-06-11 18:10:13 UTC

Permalink

Hi Ralf,

Post by Ralf Joachim
Hi Werner,
we have had problems with mavens test collector and inner classes
before. They only happend on windows systems and i was not able to
reproduce them on linux. I tried to prevent this by ignore annotations
at every class that is not a test case. At least the inner class of Col
has a ignore annotation (at inner class of ColArray it is missing).

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Post by Ralf Joachim
The only solution I found the last time we saw this problem was to
remove all inner classes and use normal ones instead. Before doing this,
- Does the problem also happen at SVN head?

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
As it looks to me this is a problem of mavens test collector that should
be reported to the maven team. Only thing we can do is to not use inner
classes in our test cases and objects. Having said that you or Lukas
will need inner classes to test all JPA features.

Well, actually, the classes I am about to commit all use inner classes
all over the place. So I do not think that's the issue. The only
difference I can see is that in most of the new classes we explicitly
use the @Test annotation to qualify a test (method), whereas in the
CPACTF we still rely on extension.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Ralf Joachim

2009-06-11 18:48:11 UTC

Permalink

Werner,

never mind I'll change from inner to normal classes.

Having said that I still don't understand why this problem only apear on
Windows but not on Linux.

Ralf

Post by Werner Guttmann
Hi Ralf,

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

Werner Guttmann

2009-06-12 19:13:39 UTC

Permalink

Hi Ralf,

I appreciate your help. I guess I will try a few things as well.

Cheers
Werner

Post by Ralf Joachim
Werner,
never mind I'll change from inner to normal classes.
Having said that I still don't understand why this problem only apear on
Windows but not on Linux.
Ralf

Post by Werner Guttmann
Hi Ralf,

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Werner Guttmann

2009-06-12 19:48:49 UTC

Permalink

Ralf,

can you please commit the new classes as well ?

Thanks
Werner

Post by Ralf Joachim
Werner,
never mind I'll change from inner to normal classes.
Having said that I still don't understand why this problem only apear on
Windows but not on Linux.
Ralf

Post by Werner Guttmann
Hi Ralf,

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Ralf Joachim

2009-06-12 20:48:23 UTC

Permalink

Hi Werner,

as far as I can see nothing is missing. My commit to fix test70 issue
also includes the new classes as you can see at:

http://fisheye.codehaus.org/changelog/castor/?cs=8240

Regards
Ralf

Post by Werner Guttmann
Ralf,
can you please commit the new classes as well ?
Thanks
Werner

Post by Ralf Joachim
Werner,
never mind I'll change from inner to normal classes.
Having said that I still don't understand why this problem only apear on
Windows but not on Linux.
Ralf

Post by Werner Guttmann
Hi Ralf,

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

Werner Guttmann

2009-06-13 09:13:19 UTC

Permalink

Hmm, you are right. It looks like I lost connectivity during the SVN
UPDATE ... and hence by source base was slightly broken.

Werner

Post by Ralf Joachim
Hi Werner,
as far as I can see nothing is missing. My commit to fix test70 issue
http://fisheye.codehaus.org/changelog/castor/?cs=8240
Regards
Ralf

Post by Werner Guttmann
Ralf,
can you please commit the new classes as well ?
Thanks
Werner

Post by Ralf Joachim
Werner,
never mind I'll change from inner to normal classes.
Having said that I still don't understand why this problem only apear on
Windows but not on Linux.
Ralf

Post by Werner Guttmann
Hi Ralf,

Which should be easy to fix, but that does not remove all problems, just
about 50% of it.

Yes, it does.

Post by Ralf Joachim
- Do you see similar problems if you execute tests with eclipse test
collector?

I have not tried, but will do.

Post by Ralf Joachim
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email