[castor-dev] [Fwd: [castor-scm] [7895] castor/trunk: Removed references to XML-APIS and Xerces from build as they are not needed with Java 5 any more]

Discussion:

Werner Guttmann

2008-09-21 17:48:20 UTC

Permalink

Hi,

I am not sure whether removing the dependency on the XML APIs is a good
one or not. In other words, I don't know right now whether we should
hardcode against Xerces or rely on the JAXB API (which admittedly is
part of the JDK). Somehow I think that we should have some discussions
about this.

Werner

-------- Original Message --------
Subject: [castor-scm] [7895] castor/trunk: Removed references to
XML-APIS and Xerces from build as they are not needed with Java 5 any more
Date: Sat, 20 Sep 2008 04:00:45 -0500 (CDT)
From: ***@codehaus.org
Reply-To: ***@castor.codehaus.org
To: ***@castor.codehaus.org

Revision
7895 <http://fisheye.codehaus.org/changelog/castor/?cs=7895>
Author
rjoachim
Date
2008-09-20 04:00:45 -0500 (Sat, 20 Sep 2008)

Log Message

Removed references to XML-APIS and Xerces from build as they are not
needed with Java 5 any more

Modified Paths

* castor/trunk/cpa/build.xml <#castortrunkcpabuildxml>
* castor/trunk/cpactf/build.xml <#castortrunkcpactfbuildxml>
* castor/trunk/maven-plugins/pom.xml <#castortrunkmavenpluginspomxml>
* castor/trunk/pom.xml <#castortrunkpomxml>
* castor/trunk/schema/pom.xml <#castortrunkschemapomxml>
* castor/trunk/xml/pom.xml <#castortrunkxmlpomxml>
* castor/trunk/xmlctf-framework/build.xml
<#castortrunkxmlctfframeworkbuildxml>

Diff

Modified: castor/trunk/cpa/build.xml (7894 => 7895)

--- castor/trunk/cpa/build.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/cpa/build.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -24,7 +24,6 @@
<pathelement location="${basedir}/../lib/jta1.0.1.jar"/>
<pathelement location="${basedir}/../lib/cglib-full-2.0.2.jar"/>
<pathelement location="${basedir}/../lib/log4j-1.2.13.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
</path>

<target name="prepare.cpa" unless="prepare.cpa.executed">

Modified: castor/trunk/cpactf/build.xml (7894 => 7895)

--- castor/trunk/cpactf/build.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/cpactf/build.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -24,7 +24,6 @@
<pathelement location="${basedir}/../lib/tests/tyrex-1.0.jar"/>
<pathelement location="${basedir}/../lib/tests/mockejb.jar"/>
<pathelement location="${basedir}/../lib/log4j-1.2.13.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
<pathelement location="${basedir}/../anttask/build/classes"/>
<pathelement location="${basedir}/../codegen/build/classes"/>
</path>

Modified: castor/trunk/maven-plugins/pom.xml (7894 => 7895)

--- castor/trunk/maven-plugins/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/maven-plugins/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -80,25 +80,6 @@
</dependency>
</dependencies>
</profile>
-
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xerces</groupId>
- <artifactId>xercesImpl</artifactId>
- <version>2.6.2</version>
- <exclusions>
- <exclusion>
- <artifactId>xml-apis</artifactId>
- <groupId>xml-apis</groupId>
- </exclusion>
- </exclusions>
- </dependency>
- </dependencies>
- </profile>
</profiles>

</project>

Modified: castor/trunk/pom.xml (7894 => 7895)

--- castor/trunk/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -611,17 +611,6 @@
<module>examples</module>
</modules>
</profile>
-
- 
</profiles>

</project>

Modified: castor/trunk/schema/pom.xml (7894 => 7895)

--- castor/trunk/schema/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/schema/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -118,20 +118,4 @@
</dependency>

</dependencies>
-
- <profiles>
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xml-apis</groupId>
- <artifactId>xml-apis</artifactId>
- <version>1.3.03</version>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
</project>

Modified: castor/trunk/xml/pom.xml (7894 => 7895)

--- castor/trunk/xml/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/xml/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -118,32 +118,4 @@
</dependency>

</dependencies>
-
- <profiles>
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xml-apis</groupId>
- <artifactId>xml-apis</artifactId>
- <version>1.3.03</version>
- </dependency>
- <dependency>
- <groupId>xerces</groupId>
- <artifactId>xercesImpl</artifactId>
- <version>2.6.2</version>
- <exclusions>
- <exclusion>
- <artifactId>xml-apis</artifactId>
- <groupId>xml-apis</groupId>
- </exclusion>
- </exclusions>
- <optional>true</optional>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
</project>

Modified: castor/trunk/xmlctf-framework/build.xml (7894 => 7895)

--- castor/trunk/xmlctf-framework/build.xml 2008-09-20 08:55:13 UTC (rev
7894)
+++ castor/trunk/xmlctf-framework/build.xml 2008-09-20 09:00:45 UTC (rev
7895)
@@ -22,7 +22,6 @@
<pathelement location="${basedir}/../anttask/build/classes"/>
<pathelement location="${basedir}/../lib/commons-logging-1.1.jar"/>
<pathelement location="${basedir}/../lib/junit_3.8.2.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
</path>

<target name="prepare.xmlctf" unless="prepare.xmlctf.executed">

------------------------------------------------------------------------

To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Ralf Joachim

2008-09-21 21:55:13 UTC

Permalink

Hi Werner,

as far as I understand things Xerces is now part of the JDK and therefor
isn't required anymore in a separate jar. That's why I removed
references to Xerces. As my tests showed that XML APIs are also not
required I removed them too.

If you think we should still use XML APIs I will revert this part of the
patch and add them once again.

Regards
Ralf

Post by Werner Guttmann
Hi,
I am not sure whether removing the dependency on the XML APIs is a good
one or not. In other words, I don't know right now whether we should
hardcode against Xerces or rely on the JAXB API (which admittedly is
part of the JDK). Somehow I think that we should have some discussions
about this.
Werner
-------- Original Message --------
Subject: [castor-scm] [7895] castor/trunk: Removed references to
XML-APIS and Xerces from build as they are not needed with Java 5 any more
Date: Sat, 20 Sep 2008 04:00:45 -0500 (CDT)
Revision
7895 <http://fisheye.codehaus.org/changelog/castor/?cs=7895>
Author
rjoachim
Date
2008-09-20 04:00:45 -0500 (Sat, 20 Sep 2008)
Log Message
Removed references to XML-APIS and Xerces from build as they are not
needed with Java 5 any more
Modified Paths
* castor/trunk/cpa/build.xml <#castortrunkcpabuildxml>
* castor/trunk/cpactf/build.xml <#castortrunkcpactfbuildxml>
* castor/trunk/maven-plugins/pom.xml <#castortrunkmavenpluginspomxml>
* castor/trunk/pom.xml <#castortrunkpomxml>
* castor/trunk/schema/pom.xml <#castortrunkschemapomxml>
* castor/trunk/xml/pom.xml <#castortrunkxmlpomxml>
* castor/trunk/xmlctf-framework/build.xml
<#castortrunkxmlctfframeworkbuildxml>
Diff
Modified: castor/trunk/cpa/build.xml (7894 => 7895)
--- castor/trunk/cpa/build.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/cpa/build.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -24,7 +24,6 @@
<pathelement location="${basedir}/../lib/jta1.0.1.jar"/>
<pathelement location="${basedir}/../lib/cglib-full-2.0.2.jar"/>
<pathelement location="${basedir}/../lib/log4j-1.2.13.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
</path>
<target name="prepare.cpa" unless="prepare.cpa.executed">
Modified: castor/trunk/cpactf/build.xml (7894 => 7895)
--- castor/trunk/cpactf/build.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/cpactf/build.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -24,7 +24,6 @@
<pathelement location="${basedir}/../lib/tests/tyrex-1.0.jar"/>
<pathelement location="${basedir}/../lib/tests/mockejb.jar"/>
<pathelement location="${basedir}/../lib/log4j-1.2.13.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
<pathelement location="${basedir}/../anttask/build/classes"/>
<pathelement location="${basedir}/../codegen/build/classes"/>
</path>
Modified: castor/trunk/maven-plugins/pom.xml (7894 => 7895)
--- castor/trunk/maven-plugins/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/maven-plugins/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -80,25 +80,6 @@
</dependency>
</dependencies>
</profile>
-
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xerces</groupId>
- <artifactId>xercesImpl</artifactId>
- <version>2.6.2</version>
- <exclusions>
- <exclusion>
- <artifactId>xml-apis</artifactId>
- <groupId>xml-apis</groupId>
- </exclusion>
- </exclusions>
- </dependency>
- </dependencies>
- </profile>
</profiles>
</project>
Modified: castor/trunk/pom.xml (7894 => 7895)
--- castor/trunk/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -611,17 +611,6 @@
<module>examples</module>
</modules>
</profile>
-
- 
</profiles>
</project>
Modified: castor/trunk/schema/pom.xml (7894 => 7895)
--- castor/trunk/schema/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/schema/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -118,20 +118,4 @@
</dependency>
</dependencies>
-
- <profiles>
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xml-apis</groupId>
- <artifactId>xml-apis</artifactId>
- <version>1.3.03</version>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
</project>
Modified: castor/trunk/xml/pom.xml (7894 => 7895)
--- castor/trunk/xml/pom.xml 2008-09-20 08:55:13 UTC (rev 7894)
+++ castor/trunk/xml/pom.xml 2008-09-20 09:00:45 UTC (rev 7895)
@@ -118,32 +118,4 @@
</dependency>
</dependencies>
-
- <profiles>
- <profile>
- <activation>
- <jdk>1.4</jdk>
- </activation>
- <dependencies>
- <dependency>
- <groupId>xml-apis</groupId>
- <artifactId>xml-apis</artifactId>
- <version>1.3.03</version>
- </dependency>
- <dependency>
- <groupId>xerces</groupId>
- <artifactId>xercesImpl</artifactId>
- <version>2.6.2</version>
- <exclusions>
- <exclusion>
- <artifactId>xml-apis</artifactId>
- <groupId>xml-apis</groupId>
- </exclusion>
- </exclusions>
- <optional>true</optional>
- </dependency>
- </dependencies>
- </profile>
- </profiles>
-
</project>
Modified: castor/trunk/xmlctf-framework/build.xml (7894 => 7895)
--- castor/trunk/xmlctf-framework/build.xml 2008-09-20 08:55:13 UTC (rev
7894)
+++ castor/trunk/xmlctf-framework/build.xml 2008-09-20 09:00:45 UTC (rev
7895)
@@ -22,7 +22,6 @@
<pathelement location="${basedir}/../anttask/build/classes"/>
<pathelement location="${basedir}/../lib/commons-logging-1.1.jar"/>
<pathelement location="${basedir}/../lib/junit_3.8.2.jar"/>
- <pathelement location="${basedir}/../lib/xerces-J_1.4.0.jar"/>
</path>
<target name="prepare.xmlctf" unless="prepare.xmlctf.executed">
------------------------------------------------------------------------
http://xircles.codehaus.org/manage_email
---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email

Werner Guttmann

2008-09-22 10:11:29 UTC

Permalink

Ralf,

I am not 100% sure about what to do here, to be honest. Yes, both XML
APIs and Xerces have been moved to the JDK starting with Java 5.0.

But being an XML tool, I thin we should make our requirements more
explicit, especially as the version of XML APIs change when switching to
Java 6. Let's have a bit of a discussion here ....

As it works (technically), no need to change the POMs right now.

Werner

Post by Ralf Joachim
Hi Werner,
as far as I understand things Xerces is now part of the JDK and therefor
isn't required anymore in a separate jar. That's why I removed
references to Xerces. As my tests showed that XML APIs are also not
required I removed them too.
If you think we should still use XML APIs I will revert this part of the
patch and add them once again.
Regards
Ralf

---------------------------------------------------------------------
http://xircles.codehaus.org/manage_email

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

http://xircles.codehaus.org/manage_email